Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volt and image func #1158

Closed
sy2nyk opened this issue Aug 26, 2013 · 2 comments
Closed

volt and image func #1158

sy2nyk opened this issue Aug 26, 2013 · 2 comments

Comments

@sy2nyk
Copy link

sy2nyk commented Aug 26, 2013

hello!
i'm write {{ image("http://notmysite/image.png", false) }}
but Volt replace this

@dreamsxin
Copy link
Contributor

This treatment is right, only when there is no internal processing of the second value of the array as a local.

        if (!local) {
                if (Z_TYPE_P(parameters) == IS_ARRAY && phalcon_array_isset_long(parameters, 1)) {
                        PHALCON_OBS_VAR(second_param);
                        phalcon_array_fetch_long(&second_param, parameters, 1, PH_NOISY);
                        if (Z_TYPE_P(second_param) == IS_BOOL) {
                                PHALCON_INIT_VAR(local);
                                ZVAL_BOOL(local, zend_is_true(second_param));
                        } else {
                                PHALCON_INIT_VAR(local);
                                ZVAL_BOOL(local, 1);
                        }
                } else {
                        PHALCON_INIT_VAR(local);
                        ZVAL_BOOL(local, 1);
                }
        }

@dreamsxin dreamsxin mentioned this issue Aug 27, 2013
@phalcon
Copy link
Collaborator

phalcon commented Aug 27, 2013

This was fixed in 1.3.0 by @dreamsxin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants