Support for array(limit, offset) as a 'limit' constructor key(Query Builder) #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this commit is broken some things, could you take a look? https://travis-ci.org/phalcon/cphalcon/builds/11106923 |
|
Hi, Sorry for this issue - I added unit tests and fixed bug - please treat this as my learning curve ;) Thanks, Kamil |
phalcon
pushed a commit
that referenced
this pull request
Sep 8, 2013
Support for array(limit, offset) as a 'limit' constructor key(Query Builder)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This time I added support for 'limit' key working as limit (int $limit, [int $offset]) method.
I'll try to code as many points as I will be able to form my previous pull request(#1205). Sorry for pushing this "one by one" but it take huge amount of time for me to get my head around C(as I'm not a C developer) so I prefer to send something before somebody else will fix/write it.
Thanks,
Kamil