Refactored, improved and optimized build script #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made all files to be generated on the fly. Previously php_phalcon.h, config.m4 and config.w32 in every build directory had to be synchronized and edited manually according to changes in Phalcon source directory - Moved the script to "build" directory, so that it is easily located by anyone, willing to compile extension. Previously, it was located in separate "scripts" directory, so the connection of it with the generated files was very unclear. - Made it possible to run 'gen-build.php' from any directory. Previously it was required to run the script only from Phalcon root directory. - Cleaned the script and broke it down into a handful of PSR-compatible classes with clearly defined responsibilities. Previously all the logic was located in one big file and was harder to understand and debug. - Moved script configuration from source file to separate files in "_resource/config". Previously configuration was mixed with the script logic. - Made source files to be included in a sorted order, so that generated files content doesn't depend on order of walking through source directory filesystem. This is very convenient for changes tracking and comparing generated files. - Optimized generation time by changing a number of regexps to plain string searches and replacements - Optimized generation time by making 32-bit and 64-bit build files to be generated based on 'safe' build files. Previously, each directory was regenerated separately, making same operations on same files. - Optimized generation time by making lines of 32-bit and 64-bit phalcon.c file to be generated based on one regexp match per source line. Previously, each 32-bit and 64-bit were doing same regexps on same lines of source code. - Updated documentation to describe the build process - Removed not used "win32" directory. Previously it was just misleading developers, who were working under Windows, because the directory seemed like a proper way to build extension, while it was not.
…s removed long ago by mistake - see revision beba42b)
|
Looks great! |
phalcon
pushed a commit
that referenced
this pull request
Sep 12, 2013
Refactored, improved and optimized build script
|
Nice job!, thanks Andrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes:
The much more detailed descriptions are in the commits.
Please, run the script on Linux and try to build Phalcon from
safeand one of optimized directories (32bitsor64bits). While I verified it on my Windows, it needs to be checked under Linux as well.