Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phalcon\Crypt safe base64 padding #12490

Merged
merged 2 commits into from
Jun 18, 2017
Merged

Phalcon\Crypt safe base64 padding #12490

merged 2 commits into from
Jun 18, 2017

Conversation

tugrul
Copy link
Contributor

@tugrul tugrul commented Dec 21, 2016

Hello!

Small description of change:

Added autopadding feature for following methods

  • Phalcon\Crypt::encryptBase64
  • Phalcon\Crypt::decryptBase64

Equal character is unsafe for url and base64 use for padding this character. base64 able to automatically padded by character length. I inspired this feature from above link.

Thanks,
Tuğrul Topuz

Added autopadding feature for following methods

- Phalcon\Crypt::encryptBase64
- Phalcon\Crypt::decryptBase64
@sergeyklay
Copy link
Contributor

We don't add changes directly to stable branches or master. Could you please send this PR to the 3.1.x branch? Note: 3.1.x not 3.0.x

@tugrul tugrul changed the base branch from master to 3.1.x December 21, 2016 11:54
@sergeyklay sergeyklay added this to the 3.1.0 milestone Dec 21, 2016
@sergeyklay sergeyklay modified the milestones: 3.1.0, 3.2.0 Mar 2, 2017
@sergeyklay sergeyklay force-pushed the 3.1.x branch 16 times, most recently from 4d3c73f to 6ef079c Compare April 5, 2017 15:25
@sjinks sjinks closed this Apr 26, 2017
@sjinks sjinks reopened this Apr 26, 2017
@sergeyklay sergeyklay closed this May 22, 2017
@sergeyklay sergeyklay reopened this May 22, 2017
@sergeyklay sergeyklay changed the base branch from 3.1.x to 3.2.x May 22, 2017 06:09
@sergeyklay sergeyklay merged commit 3f8f1c1 into phalcon:3.2.x Jun 18, 2017
@sergeyklay
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants