PDO/Adapter: decribeColumns method fixes. #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lantian
commented
Nov 17, 2013
lantian
commented
- added tinyint(1) as boolean for mysql, oracle, postresql, sqlite.
- added timestamp as date for mysql.
- decribeColumns method has been refactored in oracle, postesql, sqlite.
- added constraint creation for foreign key
| if (phalcon_memnstr_str(column_type, SL("tinyint(1)"))) { | ||
| phalcon_array_update_string_long(&definition, SL("type"), 8, PH_SEPARATE); | ||
| phalcon_array_update_string_long(&definition, SL("bindType"), 5, PH_SEPARATE); | ||
| ZVAL_STRING(column_type, "boolean", 1); // Change column type to skip size check. |
|
Ok, thanks. But what is wrong? With zval function? I'am not very familiar with C =) |
|
The issue is that the old string value is not freed — and when you assign I will tell you how to fix this a bit later — need to finish something else first. |
|
If possible, could you please use tabs instead of spaces for indentation? |
|
Thanks. Ok, i will use tabs. Tell me please, what IDE you are using? |
|
Eclipse CDT. |
phalcon
pushed a commit
that referenced
this pull request
Dec 19, 2013
PDO/Adapter: decribeColumns method fixes.
|
Thanks, could you please submit this to 1.3.0? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.