[PR] LoaderTest::testsEvents() fails on windows #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phalcon
pushed a commit
that referenced
this pull request
Nov 25, 2013
[PR] LoaderTest::testsEvents() fails on windows
|
Thanks, could you please submit this fix to 1.2.5? |
|
PR 1601 is now up for merging with 1.2.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in Phalcon\Loader.
Affected function is Phalcon\Loader::getCheckedPath() which returns invalid path on windows in some cases.
To reproduce this issue just run LoaderTest::testsEvents() on windows. See attached screenshot for result
The problem is in function phalcon_fix_path() where a conditional statement incorrectly assumes that
if a trailing path separator from users was specified it'll always be the same as system path separator.
This PR was tested on