Odd view behavior with layouts + pick

[aleemb]

I noticed some odd behavior with calling setLayout() and pick().

1. $view->setLayout('fancy');
2. $view->pick('someview');

1. Turns out if I call setLayout() then pick() then the setLayout() gets ignored. If there is a default layout, that gets picked which is worse since the framework ignores user intent (line 1).
2. The work around right now is to call pick(['view', 'layout']). This behavior is undocumented and I gleaned it by reading the C source. Is this undocumented because it's unsupported and liable to change or is this okay to use?
3. It would be nice to be able to fix this bug and leave out the undocumented array syntax since the code legibility is better and it allows full control to the user to compose views throughout the application lifecycle (set a main, a layout and a view at different stages of the app lifecycle).

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[iby]

Are you on 1.3.0 branch?

[aleemb]

Verified this issue on 1.2.5 and 1.2.6.

[iby]

It's the same for 1.3.0. In view.c on line L1277 it seems to be storing the view into array along with the layout. Second time you set the layout, the internal value changes, but that stored layout in the array from earlier pick() doesn't.

[aleemb]

I have overridden the pick() method in my custom View class that extends Phalcon\Mvc\View and the following change fixes the issue for me:

public function pick($renderView)
{
    return parent::pick([$renderView]);
}

[sergeyklay]

Fixed in 2.1.x branch