Compute both 32 and 64 bit hashes on the same arch #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
phalcon
pushed a commit
that referenced
this pull request
Jul 10, 2013
Compute both 32 and 64 bit hashes on the same arch
|
This is very useful! |
ghost
deleted the
|
Please check that it works on Windows — I don't have a Windows box at the moment and not sure it will compile properly. |
|
ok, regarding the simplified travis.yml, I merged the pull request into master, are those changes in 1.2.1 too? |
|
Yes |
|
thanks man |
|
Sorry, actually no - you will need to merge them to 1.2.1 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to generate 32bits/phalcon.c and 64bits/phalcon.c on the same computer, without having to switch to a VM.
_Rebased #813 against 1.2.1_