Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 errors in Phalcon\Tag #903

Closed
xboston opened this issue Jul 24, 2013 · 5 comments
Closed

2 errors in Phalcon\Tag #903

xboston opened this issue Jul 24, 2013 · 5 comments

Comments

@xboston
Copy link
Contributor

xboston commented Jul 24, 2013

  1. throw Phalcon\Tag\Exception: A dependency injector container is required to obtain the "escaper" service: https://gist.github.com/xboston/6068788
  2. use escape in Phalcon\Tag: https://gist.github.com/xboston/6068932
    test
    fix - replace "escapehtmlattr" => "escapehtml" in /ext/tag.c (https://github.com/phalcon/cphalcon/blob/master/ext/tag.c#L386, https://github.com/phalcon/cphalcon/blob/master/ext/tag.c#L401)
@ghost
Copy link

ghost commented Jul 25, 2013

throw Phalcon\Tag\Exception: A dependency injector container is required to obtain the "escaper" service

Isn't this the expected behavior?

@ghost
Copy link

ghost commented Jul 25, 2013

Same happens in Phalcon\Escaper::escapeJs() method 😿

@ghost
Copy link

ghost commented Jul 25, 2013

Looks like this bug is my fault and it was introduced in 1ce094c.

@xboston
Copy link
Contributor Author

xboston commented Jul 25, 2013

@sjinks throws an exception only without initializing DI

@phalcon
Copy link
Collaborator

phalcon commented Aug 8, 2013

Fixed in 1.3.0

@phalcon phalcon closed this as completed Aug 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant