Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHALCON_THROW_EXCEPTION_STR instead of phalcon_throw_exception_string #976

Merged
merged 1 commit into from Aug 2, 2013
Merged

Use PHALCON_THROW_EXCEPTION_STR instead of phalcon_throw_exception_string #976

merged 1 commit into from Aug 2, 2013

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2013

  • phalcon_throw_exception_XXX() functions do not restore the memory frame anymore (and thus can be safely used from the kernel);
  • PHALCON_THROW_EXCEPTION_STR and PHALCON_THROW_EXCEPTION_ZVAL macros take care of restoring memory frame
  • PHALCON_THROW_EXCEPTION_STRW and PHALCON_THROW_EXCEPTION_ZVALW are just aliases for phalcon_throw_exception_string and phalcon_throw_exception_zval
  • all calls to phalcon_throw_exception_string replaced with PHALCON_THROW_EXCEPTION_STR macro

phalcon pushed a commit that referenced this pull request Aug 2, 2013
Merge pull request #976 from sjinks/exceptions
d06979d 
Use PHALCON_THROW_EXCEPTION_STR instead of phalcon_throw_exception_string
@phalcon phalcon merged commit d06979d into phalcon:1.3.0 Aug 2, 2013
@ghost ghost deleted the exceptions branch August 2, 2013 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phalcon @sjinks