Changed work with foreign key and new unit tests #12937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
Jul 3, 2017
phalcon/db/dialect/mysql.zep
Outdated
| @@ -348,7 +348,11 @@ class Mysql extends Dialect | |||
| { | |||
| var sql, onDelete, onUpdate; | |||
|
|
|||
| let sql = "ALTER TABLE " . this->prepareTable(tableName, schemaName) . " ADD FOREIGN KEY `" . reference->getName() . "`(" . this->getColumnList(reference->getColumns()) . ") REFERENCES " . this->prepareTable(reference->getReferencedTable(), reference->getReferencedSchema()) . "(" . this->getColumnList(reference->getReferencedColumns()) . ")"; | |||
| let sql = "ALTER TABLE " . this->prepareTable(tableName, schemaName) . " ADD"; | |||
| if (reference->getName()) { | |||
There was a problem hiding this comment.
if (reference->getName()) { => if reference->getName() {
sergeysviridenko
force-pushed
the
3.2.foreign_key
branch
5 times, most recently
from
27ff006 to
f0d0869
Compare
sergeysviridenko
force-pushed
the
3.2.foreign_key
branch
from
f0d0869 to
9d6dfaa
Compare
sergeyklay
approved these changes
Jul 4, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
I've changed foreign key workflow: changed method addForeignKey() and added FOREIGN_KEY_CHECKS check.
Thanks