Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use db service from the model when paginating #12960

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Use db service from the model when paginating #12960

merged 2 commits into from
Jul 17, 2017

Conversation

dnapierata
Copy link
Contributor

@dnapierata dnapierata commented Jul 13, 2017 •
edited
Loading

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change: Use the db service from the model when paginating instead of assuming 'db' as the service name.

@Jurigag
Copy link
Contributor

Jurigag commented Jul 13, 2017

Also some test could be good.

@sergeyklay sergeyklay added this to the 3.2.x milestone Jul 17, 2017
@sergeyklay sergeyklay merged commit de4d075 into phalcon:3.2.x Jul 17, 2017
@sergeyklay
Copy link
Contributor

Thank you

@sergeyklay sergeyklay mentioned this pull request Jul 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jurigag Jurigag Jurigag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@dnapierata @Jurigag @sergeyklay