Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2291 #2333

Closed
wants to merge 1 commit into from
Closed

Fix #2291 #2333

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2014

Middlewares do not stop operation when before event triggered in Micro as documented http://docs.phalconphp.com/en/latest/reference/micro.html#middleware-events.

This PR makes return false and stop method in middleware work as same as which in anonymous function for before event.

@ogarbe
Copy link
Contributor

ogarbe commented Apr 14, 2014

Hello, please rebase your pull request and reopen it to 1.3.2

@ghost ghost closed this Apr 15, 2014
@ghost ghost deleted the 1.3.1 branch April 15, 2014 05:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants