Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open terminal here" in new File browser does not work correctly on Windows #16393

Closed
astares opened this issue Apr 2, 2024 · 4 comments
Closed
Labels
To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Milestone

Comments

@astares
Copy link
Member

astares commented Apr 2, 2024

Open the new file browser and select "Open terminal here" when you are on a Windows machine:

image

This fails with an error:

image

One has to change the method StFileBrowserOpenTerminalCommand>>#openWindowsTerminalOn:
from

openWindowsTerminalOn: aPath

	^ String streamContents: [ : stream |
		stream
			<< 'start cmd.exe /K "cd /d ';
			<< aPath;
			<< '"' ]

to

openWindowsTerminalOn: aPath

	^ String streamContents: [ : stream |
		stream
			<< 'start cmd.exe /K "cd /d ';
			<< aPath fullName;
			<< '"' ]

to make it work. Should be fixed before P12 release.

@astares astares added this to the 12.0.0 milestone Apr 2, 2024
@astares astares added To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12 labels Apr 2, 2024
@astares
Copy link
Member Author

astares commented Apr 2, 2024

Need to be fixed in https://github.com/pharo-spec/NewTools

GitHub
All development tools for Pharo, developed with Spec - pharo-spec/NewTools

@hernanmd
Copy link
Member

hernanmd commented Apr 2, 2024

Thanks for reporting, and the quick fix.
PR in pharo-spec/NewTools#732

@jecisc
Copy link
Member

jecisc commented Apr 2, 2024

Merged

@jecisc jecisc closed this as completed Apr 2, 2024
@astares
Copy link
Member Author

astares commented Apr 2, 2024

@hernanmd thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Projects
None yet
Development

No branches or pull requests

3 participants