Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sorting): Make many tables in inspector extensions properly sortable #924

Draft
wants to merge 1 commit into
base: Pharo13
Choose a base branch
from
Draft

fix(sorting): Make many tables in inspector extensions properly sortable #924

wants to merge 1 commit into from

Conversation

guillep
Copy link
Contributor

@guillep guillep commented Dec 20, 2024

Fix pharo-project/pharo#17522
Depends on: pharo-spec/Spec#1686

Alphabetic sorting does not deal correctly with numeric values. They are first translated to string, then sorted.
This PR decouples evaluation from formatting for many of those extensions

@guillep
fix(sorting): Make many tables in inspector extensions properly sortable
2fb8e3b 
Alphabetic sorting does not deal correctly with numeric values.
They are first translated to string, then sorted.
This PR decouples evaluation from formatting for many of those extensions
@Ducasse
Copy link
Contributor

Ducasse commented Dec 20, 2024

Guille apparently this makes 61 tests to fail

StBreadcrumbPresenterTest
✗ #testRoot (0ms)

StNavigationSystemTest
✗ #testWhenCustomizeFilterWithoutDefaultFilterShouldFilterDropListPresenterIncludeDefaultFilterAndSelectIt (1ms)
✗ #testWhenCurrentDirectoryChangeshouldNewFileDialogOpenOnTheNewDirectory (0ms)
✗ #testWhenOpenADirectoryShouldDisplayHisChildrenFilterByCurrentFilter (0ms)
✗ #testWhenFilesListSelectionChangedAndIsAJPGShouldpreviewContentPresenterIsNotNil (0ms)
✗ #testCustomizationWhenChangeCollectionOfPreviewerShouldBeSet (0ms)
✗ #testInitializeFilterDropListSelectedItemShouldBeDefaultFilter (0ms)
✗ #testWhenClickAnAfterHistoryButtonIfThereAreHistoryShouldComeBackTheGoodDirectory (0ms)
✗ #testInitializeCurrentPathTextInputShouldSet (0ms)
✗ #testWhenCustomizeFilterShouldFilterDropListPresenterIncludeIt (0ms)
✗ #testWhenClickAnBeforeHistoryButtonIfThereAreHistoryShouldComeBackToTheLastDirectoryVisited (0ms)
✗ #testOpenFolder (0ms)
✗ #testWhenPathTextInputPresenterAcceptShouldChangeFileListWithTheGoodContent (0ms)
✗ #testInitializeShouldOnlySeeNotHiddenFile (0ms)

StFileFilterTest
✗ #testPredicate (1ms)
✗ #testFilterExtensions (0ms)
✗ #testFoldersOnly (0ms)
✗ #testHiddenFiles (0ms)
✗ #testFilterMatching (0ms)

StOpenFilePresenterTest
✗ #testSetTitle (0ms)
✗ #testIsRootDirectoryWindowsDrive (0ms)
✗ #testWhenChangeDirectoryShouldFilesListContainsHisChildren (0ms)
✗ #testSelectFileWithMultipleSelection (0ms)
✗ #testWhenAddingBookmarkOnDefaultBookmarksShouldBeAddToAllInstance (0ms)
✗ #testWhenAddingBookmarkOnIsolateBookmarksShouldBeAddToAllInstance (0ms)
✗ #testWhenAddACollectionOfBookmarkToCustomBookmarkShouldBeAddedToBookmarkTreeTable (0ms)
✗ #testSelectFile (0ms)
✗ #testSelectedEntriesMultipleSelection (0ms)
✗ #testOpen (0ms)
✗ #testMultipleExtensions (0ms)
✗ #testExtensions (0ms)
✗ #testSelectedEntriesSingleSelection (0ms)
✗ #testSelectFileWithMultipleSelectionAccessingEntries (0ms)
✗ #testOpenFolder (0ms)
✗ #testIsRootDirectory (0ms)

StJPEGFilterTest
✗ #testPredicate (1ms)

StBitmapFilterTest
✗ #testPredicate (3ms)

StNilFilterTest
✗ #testPredicate (0ms)

StDirectoryFilterTest
✗ #testPredicate (1ms)

StSaveFilePresenterTest
✗ #testIsRootDirectory (1ms)
✗ #testSetNameText (0ms)
✗ #testOpen (0ms)
✗ #testIsRootDirectoryWindowsDrive (0ms)
✗ #testWhenAddingBookmarkOnIsolateBookmarksShouldBeAddToAllInstance (0ms)
✗ #testOpenFolder (0ms)
✗ #testWhenAddACollectionOfBookmarkToCustomBookmarkShouldBeAddedToBookmarkTreeTable (0ms)
✗ #testWhenChangeDirectoryShouldFilesListContainsHisChildren (0ms)
✗ #testWhenAddingBookmarkOnDefaultBookmarksShouldBeAddToAllInstance (0ms)

StPNGFilterTest
✗ #testPredicate (2ms)

StOpenDirectoryPresenterTest
✗ #testDefaultDirectory (2ms)
✗ #testWhenAddingBookmarkOnIsolateBookmarksShouldBeAddToAllInstance (0ms)
✗ #testWhenAddACollectionOfBookmarkToCustomBookmarkShouldBeAddedToBookmarkTreeTable (0ms)
✗ #testWhenChangeDirectoryShouldFilesListContainsHisChildren (0ms)
✗ #testOpenFolder (0ms)
✗ #testIsRootDirectoryWindowsDrive (0ms)
✗ #testOpen (0ms)
✗ #testSelectDirectory (0ms)
✗ #testSelectNonexistingDirectory (0ms)
✗ #testWhenAddingBookmarkOnDefaultBookmarksShouldBeAddToAllInstance (0ms)
✗ #testIsRootDirectory (0ms)

StGIFFilterTest
✗ #testPredicate (2ms)

Executed 813 Tests with 0 Failures and 61 Errors in 54.89s.

@guillep
Copy link
Contributor Author

guillep commented Dec 23, 2024

Yes, because it depends on pharo-spec/Spec#1686 being merged first

@guillep guillep marked this pull request as draft December 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting by date does not sort by date in the fileBrowser
2 participants
@guillep @Ducasse