-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logic of changeFactory references is suspicious #3173
Comments
To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. It will be closed in 1 month if no further activity occurs. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.
|
I do not like the stale robot can we remove it.! |
Why? Do you want to keep all issues that nobody cares about? Sure these mails are annoying but they help clean stuff and concentrate on things somebody cares, no? |
Because I have to write on the issues that I want to work on!!! |
You mean issues you want to work on but didn‘t in the last months? |
Exactly and seriously I'm not the only one to be annoyed by this stale robot. Marcus changed the delay. |
I‘m not a fan of the stale robit and won‘t defend it. I‘m just asking myself if in a couple of month from now there is moaning about the very growing issue list where too many issues are okd and nobody cares. What is the alternative for this ? |
Tagging and encouraging people to contribute. |
This issue looks more like a small project than an actionable issue. |
RefactoryChangeFactory class >> instance
^ RBRefactoryChangeManager instance changeFactory
RefactoringChangeManager class >> instance
^ Instance ifNil: [ Instance := self basicNew initialize ]
RefactoringChangeManager >> changeFactory
^ RBRefactoryChangeFactory new
I do not see the point to pass via the singleton if this is just to return a fresh instance each time.
The text was updated successfully, but these errors were encountered: