Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundPixels: true image scaling pixels off #6874

Closed
saintflow47 opened this issue Jul 24, 2024 · 5 comments
Closed

RoundPixels: true image scaling pixels off #6874

saintflow47 opened this issue Jul 24, 2024 · 5 comments

Comments

@saintflow47
Copy link

saintflow47 commented Jul 24, 2024

Version

  • Phaser Version:
    3.85.0.beta-2
  • Operating system:
    W10
  • Browser:
    Chrome

Description

https://phaser.io/sandbox/x8mumpYw

Basically this code leads to me having the image not fully cover the screen in the new beta with RoundPixels: true. setting roundPixels false or rolling the version back leads to it working as expected again.

2024_07_24_141300

I have encountered another issue that might be related as well that i havent seen before, its thin lines appearing between the outline blocks at certain window resolutions

2024_07_27_005640

@photonstorm
Copy link
Collaborator

I can't replicate this - can you have a look here and tell me what needs changing please: https://labs.phaser.io/view.html?src=src/bugs/6874%20rp.js

I've uploaded 3.85 Beta 1, Beta 2 and the current build of master ('dev' version) which you can switch between

@photonstorm
Copy link
Collaborator

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

@phaserjs phaserjs deleted a comment from greptile-apps bot Sep 9, 2024
@photonstorm
Copy link
Collaborator

@saintflow47 re: your Discord message. I tested your Sandbox and the labs link above in v3.85 and it fills the canvas entirely (where-as 3.80 gives you the green line across the bottom) - do you have an updated sandbox that demonstrates this with 3.85?

@photonstorm photonstorm reopened this Sep 9, 2024
@saintflow47
Copy link
Author

Updated Sandbox to show the issue: https://phaser.io/sandbox/QQFb7SU5

@photonstorm
Copy link
Collaborator

Ok, do a fresh build from the main branch of 3.85.2 and then test that please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants