Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI Traversing misses uris within double quote marks #60

Closed
Kvizer opened this issue Jun 22, 2020 · 5 comments
Closed

URI Traversing misses uris within double quote marks #60

Kvizer opened this issue Jun 22, 2020 · 5 comments
Assignees

Comments

@Kvizer
Copy link

Kvizer commented Jun 22, 2020

Example CSS:

.tp-transparentimg { content: "url(../assets/transparent.png)"; }

I would expect that WikiVisitUrls.java example will print url, but it does not.

If you remove double quote marks from css, the WikiVisitUrls example works fine!

@phax phax self-assigned this Jun 22, 2020
@phax
Copy link
Owner

phax commented Jun 22, 2020

Well, that is an issue, because if it is a String, than the parser treats it as a String. If I remove the quotes it is still a String I would need to parse separately.
You basically need to create a preprocessor that removes the superfluous quotes, and than parse it. But adding this non -standard behaviour to the core does not make sense to me...

@Kvizer
Copy link
Author

Kvizer commented Jun 22, 2020

according "CSS content Property" example from https://www.w3schools.com/cssref/pr_gen_content.asp

we can have css like

a::after { content: " (" attr(href) ")"; }

so i guess it's common behavior that someone insert url in double quote marks

@Kvizer
Copy link
Author

Kvizer commented Jun 22, 2020

Thanks for helping me clear my "css example", I appreciate your time.

@phax
Copy link
Owner

phax commented Jun 22, 2020

You have quite a big fan base ;-)

If you change your code to

a::after { content: " (" url(/whatever.png) ")"; }

than it is already returned in the visitor. That is imho the same as #59 fixed for the v6.2.3 release.
Please confirm.

@phax
Copy link
Owner

phax commented Jul 1, 2020

Seems to work :) If not, feel free to re-open

@phax phax closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants