Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business Card v3 #210

Closed
tmhide opened this issue Apr 22, 2022 · 2 comments
Closed

Business Card v3 #210

tmhide opened this issue Apr 22, 2022 · 2 comments

Comments

@tmhide
Copy link

tmhide commented Apr 22, 2022

I tried PUT /businesscard/{participantIdentifier}, but the language attribute did not register.
According to the following implementation, phoss-smp does not support Business Card v3 via the API.

I tried the following update query, but GET /businesscard/{participantIdentifier} did not output in Business Card v3 format.

update smp_bce set  name = '[{"name":"test","language":"en"}]' where id = 'idxxx'

I would like to see support for MultilingualNameType even if it is only for the REST API (GET/PUT), do you have any plans?

@tmhide
Copy link
Author

tmhide commented Apr 22, 2022

Below is the conversation so far.
phax/phoss-directory#62

@phax
Copy link
Owner

phax commented May 15, 2022

This will be part of the v5.7.0 release.
I added an additional column called names that is created using FlyWay migration v18.
The column name is used only if there is a single name with a single language.
If there is either one name with a language or more than one name, the data is stored in JSON format into the names column.

An example DB data structure looks like this:

[
  {
    "name": "Name1",
    "language": "de"
  },
  {
    "name": "Name2",
    "language": "en"
  }
]

So your statement on top needs to be changed to

update smp_bce set  name=null, names = '[{"name":"test","language":"en"}]' where id = 'idxxx'

@phax phax closed this as completed May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants