Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new k8s Versions #68

Merged
merged 66 commits into from
Jul 5, 2022
Merged

Support new k8s Versions #68

merged 66 commits into from
Jul 5, 2022

Conversation

phenixblue
Copy link
Owner

@phenixblue phenixblue commented Jun 29, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation

/kind feature

/kind release

What this PR does / why we need it:

Adjusts the init code to support new K8s API versions for certificates and such. This enabled support for newer k8s versions (v1.21+).

Which issue(s) this PR fixes:

Fixes #57

Special notes for your reviewer:

Picks up where #65 left off

Does this PR introduce a user-facing change?:


Additional documentation e.g., usage docs, etc.:

- [Usage]: README.md
- [Kubernetes CSR]: https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests
- [Kubernetes API Migration]: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#lease-v122
- [EKS CSR]: https://docs.aws.amazon.com/eks/latest/userguide/cert-signing.html

mariomcosta
mariomcosta previously approved these changes Jul 4, 2022
@phenixblue phenixblue changed the title Support new k8s Versions [WIP] Support new k8s Versions Jul 4, 2022
@phenixblue phenixblue changed the title [WIP] Support new k8s Versions Support new k8s Versions Jul 4, 2022
@phenixblue phenixblue requested a review from ilrudie July 4, 2022 21:40
ilrudie
ilrudie previously approved these changes Jul 5, 2022
Copy link
Collaborator

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of non-blocking comments/questions but I think it's good to go if you don't care to address those in this MR so I'll go ahead and approve now.

.github/workflows/ci-e2e-checks.yaml Outdated Show resolved Hide resolved
.github/workflows/ci-e2e-checks.yaml Show resolved Hide resolved
Copy link
Collaborator

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phenixblue phenixblue merged commit 82bb215 into master Jul 5, 2022
@phenixblue phenixblue deleted the suport-new-k8s branch July 5, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imageswap-init should use v1 of CertificateSigningRequest instead of v1beta1
3 participants