Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing color mode icons #523

Closed
cblavier opened this issue Dec 6, 2024 · 0 comments · Fixed by #526
Closed

Missing color mode icons #523

cblavier opened this issue Dec 6, 2024 · 0 comments · Fixed by #526
Assignees
@cblavier
Labels
bug Something isn't working

Comments

@cblavier
Copy link
Contributor

cblavier commented Dec 6, 2024

Anyone not using FontAwesome won't be able to see color mode icons (light / dark / system)

For non-FontAwesome users, the Storybook icons are still provided by FontAwesome but bundled in font.css and fa-*.tff files.
We should add missing icons (free variants) in the bundle.
@cblavier cblavier added the bug Something isn't working label Dec 6, 2024
@cblavier cblavier self-assigned this Dec 6, 2024
@cblavier cblavier linked a pull request Dec 6, 2024 that will close this issue
Fixed missing color mode icons #526
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cblavier cblavier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed missing color mode icons phenixdigital/phoenix_storybook
1 participant
@cblavier