Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color_mode hook is now checking if color_mode option is enabled #528

Conversation

cblavier
Copy link
Contributor

@cblavier cblavier commented Dec 6, 2024

No description provided.

@cblavier cblavier linked an issue Dec 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (dbf72b7) to head (da107b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #528   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          38       38           
  Lines        2052     2052           
=======================================
  Hits         1969     1969           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cblavier cblavier merged commit 10a843f into main Dec 6, 2024
3 checks passed
@cblavier cblavier deleted the 527-dark-mode-may-be-active-even-when-color_mode-option-is-disabled branch December 6, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode may be active even when color_mode option is disabled
1 participant