Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about unused resources #195

Open
ielis opened this issue Sep 26, 2023 · 1 comment
Open

Warn about unused resources #195

ielis opened this issue Sep 26, 2023 · 1 comment
Assignees

Comments

@ielis
Copy link
Collaborator

ielis commented Sep 26, 2023

The validator should point out presence of unused MetaData > Resources, that is resources that do not correspond to any OntologyClass.

@julesjacobsen @pnrobinson the Phenopacket Schema documentation requires presence of resources for used OntologyClasses, but does not explicitly forbids unused resources. The closest thing I found is a statement:

This element contains a listing of the ontologies/resources referenced in the phenopacket.

in MetaData > resources explanation.

An unused resource should produce either error or warning. I think warning is more appropriate.

@julesjacobsen @pnrobinson any thoughts?

@pnrobinson
Copy link
Collaborator

A warning would be good. On the other hand, it might mean that somebody used a certain version of some ontology and did not find any matches, but still the ontology would belong in the metadata, so I am not sure it is even a warning.

@ielis ielis self-assigned this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants