From f8e4a1558e865dcd034911b8db7b9ddd578e7743 Mon Sep 17 00:00:00 2001 From: Philippe Blain Date: Wed, 30 Sep 2020 09:25:43 -0400 Subject: [PATCH] ice_grid: initialize 'uvm' to 0 In subroutine 'makemask', the array 'uvm' is initialized in a loop on indices {ilo, ihi} and {jlo, jhi}, but is then used in a loop on indices {1, nx_block} and {1, ny_block}, causing an uninitialized value to be used (at line 1672). Initialize the whole array to zero first, to avoid using uninitialized values. The initialization to zero is actually commented out, following https://github.com/CICE-Consortium/CICE/pull/180, so uncomment it. --- cicecore/cicedynB/infrastructure/ice_grid.F90 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cicecore/cicedynB/infrastructure/ice_grid.F90 b/cicecore/cicedynB/infrastructure/ice_grid.F90 index 34b37cf29..505b1d539 100644 --- a/cicecore/cicedynB/infrastructure/ice_grid.F90 +++ b/cicecore/cicedynB/infrastructure/ice_grid.F90 @@ -1635,7 +1635,7 @@ subroutine makemask !----------------------------------------------------------------- bm = c0 -! uvm = c0 + uvm = c0 !$OMP PARALLEL DO PRIVATE(iblk,i,j,ilo,ihi,jlo,jhi,this_block) do iblk = 1, nblocks