Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance_types are made into a Set, which breaks the ordering #1152

Closed
Makeshift opened this issue Sep 1, 2021 · 0 comments · Fixed by #1154
Closed

instance_types are made into a Set, which breaks the ordering #1152

Makeshift opened this issue Sep 1, 2021 · 0 comments · Fixed by #1154
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Makeshift
Copy link
Contributor

Makeshift commented Sep 1, 2021

I'm unsure exactly how templates are picked and in what order in this module, but when specifying a list of instances they're converted into a Set, which alphabetises them and means that the order is broken. Eg, if passed an array:

instance_types = ["z1d.large", "r5a.large", "r5.large", "r5ad.large", "r5n.large", "t3.xlarge", "m5a.xlarge", "t2.xlarge", "m5.xlarge", "m4.xlarge"]

It will be converted into a Set, which becomes:

instance_types = [ "m4.xlarge", "m5.xlarge", "m5a.xlarge", "r5.large", "r5a.large", "r5ad.large", "r5n.large", "t2.xlarge", "t3.xlarge", "z1d.large" ]

This means that the spot instances that are spawning are preferring m4.xlarge rather than the z1d.large that I'd prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants