fix install_config_runner -> install_runner

[marekaf]

060daac#diff-e9624b388e62ca51cf1fe073eb0919588e8c36a1143ecdb49580996a89f13beb

060daac#r61361220

I believe this was forgotten to be changed in ubuntu example

Afrer upgrading I got for the ubuntu userdata.sh this:

│ Invalid value for "vars" parameter: vars map does not contain key "install_config_runner", referenced at ./templates/user-data.sh.tpl:74,3-24.
╵

[npalm]

LGTM

[ScottGuymer]

Can you also add ${start_runner} to the template.

Then its good to merge!

[marekaf]

done, thanks!

[ScottGuymer]

Great! Thanks for the contribution.

[yusufharip]

Hi @ScottGuymer

I got this error using ubuntu example in /var/log/user-data.log

sudo: unknown user: ec2-user
sudo: unable to initialize policy plugin
++ awk '{print int($1/3600)":"int(($1%3600)/60)":"int($1%60)}' /proc/uptime
+ echo 'Starting runner after 0:4:24'
Starting runner after 0:4:24
+ echo 'Starting the runner as user ec2-user'
Starting the runner as user ec2-user
+ [[ persistent = \e\p\h\e\m\e\r\a\l ]]
+ echo 'Installing the runner as a service'
Installing the runner as a service
+ ./svc.sh install ec2-user
/var/lib/cloud/instance/scripts/part-001: line 194: ./svc.sh: No such file or directory
+ echo 'Starting the runner in persistent mode'
Starting the runner in persistent mode
+ ./svc.sh start
/var/lib/cloud/instance/scripts/part-001: line 196: ./svc.sh: No such file or directory

Did I miss something?

This is my main.tf configuration

locals {
  environment = "ubuntu"
  aws_region  = "asia-southeast-1"
}

resource "random_id" "random" {
  byte_length = 20
}

resource "aws_kms_key" "github" {
  is_enabled = true
}

module "runners" {
  source 				  = "philips-labs/github-runner/aws"
  aws_region 				  = local.aws_region
  vpc_id     				  = module.vpc.vpc_id
  subnet_ids 				  = module.vpc.private_subnets
  scale_up_reserved_concurrent_executions = -1
  instance_types			  = ["t3a.small"]
  volume_size				  = 10
  environment 				  = local.environment
  kms_key_arn  				  = aws_kms_key.github.arn
  tags = {
    Project = "runners"
  }

  github_app = {
    key_base64     = var.github_app_key_base64
    id             = var.github_app_id
    webhook_secret = random_id.random.hex
  }

  webhook_lambda_zip                = "lambdas-download/webhook.zip"
  runner_binaries_syncer_lambda_zip = "lambdas-download/runner-binaries-syncer.zip"
  runners_lambda_zip                = "lambdas-download/runners.zip"
  enable_organization_runners       = true 
  runner_extra_labels               = "githubrunner"
  enable_ssm_on_runners 	    = true

  userdata_template = "./templates/user-data.sh"
  ami_owners        = ["099720109477"] # Canonical's Amazon account ID

  ami_filter = {
    name = ["ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-*"]
  }

  block_device_mappings = {
    # Set the block device name for Ubuntu root device
    device_name = "/dev/sda1"
  }

  runner_log_files = [
    {
      "log_group_name" : "syslog",
      "prefix_log_group" : true,
      "file_path" : "/var/log/syslog",
      "log_stream_name" : "{instance_id}"
    },
    {
      "log_group_name" : "user_data",
      "prefix_log_group" : true,
      "file_path" : "/var/log/user-data.log",
      "log_stream_name" : "{instance_id}/user_data"
    },
    {
      "log_group_name" : "runner",
      "prefix_log_group" : true,
      "file_path" : "/home/runners/actions-runner/_diag/Runner_**.log",
      "log_stream_name" : "{instance_id}/runner"
    }
  ]

  idle_config = [{
   cron      = "* * 9-19 * * 1-5"
   timeZone  = "Asia/Jakarta"
   idleCount = 4
  }]
}

[ScottGuymer]

@yusufharip it seems like there might be some more issues with this example.

Just quickly looking at the script I'm guessing that the ${install_runner} is being run before the directory is being set.. Which means that then the ${start_runner} is being run it is in a different directory to where the runner is installed.

[yusufharip]

@ScottGuymer
I think I got another problem that causes this, seems like I can't download github runner.

+ echo 'Reteieved REGION from AWS API (ap-southeast-1)'
Reteieved REGION from AWS API (ap-southeast-1)
+ echo 'Downloading the GH Action runner from s3 bucket s3://ubuntu-dist-s0l69799asw2m13krm5sklsp/actions-runner-linux.tar.gz'
Downloading the GH Action runner from s3 bucket s3://ubuntu-dist-s0l69799asw2m13krm5sklsp/actions-runner-linux.tar.gz
+ aws s3 cp s3://ubuntu-dist-s0l69799asw2m13krm5sklsp/actions-runner-linux.tar.gz actions-runner.tar.gz --region ap-southeast-1
fatal error: An error occurred (403) when calling the HeadObject operation: Forbidden
+ echo 'Un-tar action runner'
Un-tar action runner
+ tar xzf ./actions-runner.tar.gz
tar (child): ./actions-runner.tar.gz: Cannot open: No such file or directory

[ScottGuymer]

Thats probably related to #1542

[yusufharip]

Ah yes, the latest release fix my problem. But I found this again.

sudo: unknown user: ec2-user
sudo: unable to initialize policy plugin
++ awk '{print int($1/3600)":"int(($1%3600)/60)":"int($1%60)}' /proc/uptime
+ echo 'Starting runner after 0:2:21'
Starting runner after 0:2:21
+ echo 'Starting the runner as user ec2-user'
Starting the runner as user ec2-user
+ [[ persistent = \e\p\h\e\m\e\r\a\l ]]
+ echo 'Installing the runner as a service'
Installing the runner as a service
+ ./svc.sh install ec2-user
/var/lib/cloud/instance/scripts/part-001: line 196: ./svc.sh: No such file or directory
+ echo 'Starting the runner in persistent mode'
Starting the runner in persistent mode
+ ./svc.sh start
/var/lib/cloud/instance/scripts/part-001: line 198: ./svc.sh: No such file or directory

[ScottGuymer]

It seems like the ec2-user is not available on the vm you are using.

sudo: unknown user: ec2-user

You could try setting a different user or run as root.

If this persists lets create a new issue for it and move the discussion out of this PR.

[npalm]

The default example which we provide is based on AWS linux2, which means ec2-user is the default. For ubuntu that will be ubuntu for example

[yusufharip]

Hi @ScottGuymer @npalm I have fix this issue yesterday by modifying my user-data.sh.
I modified it to run as a root and works like a charm. Thank you.