Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable auto update of github runner #1694

Closed
npalm opened this issue Feb 2, 2022 · 1 comment
Closed

Add option to disable auto update of github runner #1694

npalm opened this issue Feb 2, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@npalm
Copy link
Member

npalm commented Feb 2, 2022

Description

GitHub released an option to disable the auto update of runners. https://github.blog/changelog/2022-02-01-github-actions-self-hosted-runners-can-now-disable-automatic-updates/ Now we can add an option to support this by the module

Default

Question is what should be the default?

  • Without AMI. Keep the current behaviror. With the S3 we haven't any issue for months.
  • With the AMI. The whole purpose of the AMI is to boot as fast as we can. So think we should consider to disable the auto update for AMI's. AMI templates are provided as example
@npalm npalm added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 2, 2022
@npalm npalm mentioned this issue Feb 24, 2022
Merged
6 tasks
@ScottGuymer
Copy link
Member

This feature is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScottGuymer @npalm