Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to toggle access to EC2 instance tags #2592

Merged
merged 3 commits into from
Nov 8, 2022
Merged

feat: Allow to toggle access to EC2 instance tags #2592

merged 3 commits into from
Nov 8, 2022

Conversation

MGSousa
Copy link
Contributor

@MGSousa MGSousa commented Oct 29, 2022

Added variable option for toggle (enabled/disabled) access to EC2 instance tags through metadata service.

@npalm npalm self-requested a review October 31, 2022 13:46
npalm
npalm reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MGSousa looks good, but curious in what case do you disable the metadaservice_tags? The instance start-up requires on tags. Or do you use an alternative user_data script to start your runners in such way you are not requiring the tags.

@MGSousa
Copy link
Contributor Author

MGSousa commented Oct 31, 2022 •
edited
Loading

@MGSousa looks good, but curious in what case do you disable the metadaservice_tags? The instance start-up requires on tags. Or do you use an alternative user_data script to start your runners in such way you are not requiring the tags.

For this case, I need to disable this metadata service since this restricts "spacing" in tags (aws/aws-sdk#410), and for now, it's the only solution.
Also, I am using a custom user_data.sh script for starting the runners which calls the describe-tags for each instance.

npalm
npalm requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to run a quick deployment test. Added a small suggestion

variables.tf Outdated Show resolved Hide resolved
modules/runners/variables.tf Outdated Show resolved Hide resolved
MGSousa and others added 2 commits November 4, 2022 16:17
@MGSousa @npalm
Update variable description
66227ad 
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
@MGSousa @npalm
Update variable description
07d0a41 
Updated description for the metadata_options variable

Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
@npalm npalm merged commit 55fba22 into philips-labs:develop Nov 8, 2022
forest-releaser bot pushed a commit that referenced this pull request Nov 8, 2022
@semantic-release-bot
chore(release): 1.15.0 [skip ci]
0b0916d 
## [1.15.0](v1.14.0...v1.15.0) (2022-11-08)

### Features

* Allow to toggle access to EC2 instance tags ([#2592](#2592)) ([55fba22](55fba22))

### Bug Fixes

* Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](#2614)) ([7ac65e5](7ac65e5))
npalm pushed a commit that referenced this pull request Nov 17, 2022
@semantic-release-bot @npalm
chore(release): 1.15.0 [skip ci]
ea3a426 
## [1.15.0](v1.14.0...v1.15.0) (2022-11-08)

### Features

* Allow to toggle access to EC2 instance tags ([#2592](#2592)) ([55fba22](55fba22))

### Bug Fixes

* Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](#2614)) ([7ac65e5](7ac65e5))
npalm pushed a commit that referenced this pull request Dec 13, 2022
@semantic-release-bot @npalm
chore(release): 1.15.0 [skip ci]
18746fb 
## [1.15.0](v1.14.0...v1.15.0) (2022-11-08)

### Features

* Allow to toggle access to EC2 instance tags ([#2592](#2592)) ([55fba22](55fba22))

### Bug Fixes

* Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](#2614)) ([7ac65e5](7ac65e5))
@forest-releaser forest-releaser bot mentioned this pull request Dec 28, 2022
Closed
@forest-releaser forest-releaser bot mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGSousa @npalm