feat(runner): allow linux starter-runner script to retrieve labels without with IMDSv2 tags option #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
requested changes
Dec 28, 2022
|
@MGSousa can you update the PR to merge to main (and rebase) we stopped the develop branch. See also the announcements in the readme. Sorry for the incovience. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@npalm Why is this PR stale? |
npalm
changed the title
- Fix start script to read ssm config tag via SDK - Update multi runner example, one runner is now using SDK instead of meta data tags
npalm
approved these changes
Mar 1, 2023
|
@MGSousa Thanks for you work, I made a few minor adjustments on your branch. Please can you cross check the changes? |
|
@npalm Looks good! Thanks |
npalm
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use the default start-runner script in Linux to be acknowledge with Instance Metadata Service Tags as an option to be settled out (to describe or to use an endpoint to fetch them), without the need for custom starter scripts.