fix(syncer): enable SSE by default for dist bucket #3048
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Amazon has enabled SSE by default for S3 buckets since Jan 2023. Currently the module does set the default rule to null, which results that every run detects a change in SSE for the dist bucket. By setting the default to SSE the Terraform default config is back in sync with the AWS default.
Problem
Every Terraform run tries to change the bucket encryption settings due to Amazon default changes:
Verifications
Deployed and tested with the default example