Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tags to aws resources #3549

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Conversation

gmcoringa
Copy link
Contributor

Add tags to AWS resources that do not have any tags.

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmcoringa thx

We use tag_all to ensure tags are set.

@npalm npalm merged commit c747139 into philips-labs:main Oct 26, 2023
19 checks passed
npalm pushed a commit that referenced this pull request Oct 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.7.0](v4.6.0...v4.7.0)
(2023-10-26)


### Features

* Add public IP association to github runner
([#3547](#3547))
([1a25b2c](1a25b2c))


### Bug Fixes

* add tags to aws resources
([#3549](#3549))
([c747139](c747139))
* restrict runner security group to only ingress
([#3564](#3564))
([e63fdc5](e63fdc5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
npalm added a commit that referenced this pull request Oct 26, 2023
Add tags to AWS resources that do not have any tags.

Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
@gmcoringa gmcoringa deleted the fix_aws_missing_tags branch October 26, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants