Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS provider version specifier is too specific preventing AWS provider updates #3709

Closed
richbecks opened this issue Jan 9, 2024 · 2 comments

Comments

@richbecks
Copy link

richbecks commented Jan 9, 2024

The AWS provider is locked as ~> 5.27.0 which only allows floating versions on the patch version. It looks like this precision was added by mistake as previous versions were locked by major only using a ~> <major>.<minor> specifier.

This change prevents the use of the module with any other terraform that requires AWS beyond 5.27.

Worse still, I and many other people may have already been using an AWS provider later than 5.27, and when we update the github-runner module to a version with the locked down version, it may result in a version downgrade, which generates warnings such as...

Warning: Failed to decode resource from state                                                                                                                                                                                                                               │
│                                                                                                                                                                                                                                                                           │
│ Error decoding "module.github-runner.module.runners.aws_cloudwatch_log_group.scale_down" from prior state: unsupported attribute "log_group_class"

The specifier should be marked as ~> 5.27

This affects release v5.6.0 of this module.

@richbecks
Copy link
Author

Great, look like this is being address in #3708 by @sthristov

@npalm
Copy link
Member

npalm commented Jan 10, 2024

PR is merged, thanks for reporting.

@npalm npalm closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants