Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing webhook_events_workflow_job_queue_policy to multi-runner queue #3848

Merged

Conversation

veronicatjan
Copy link
Contributor

Add missing aws_sqs_queue_policy.webhook_events_workflow_job_queue_policy to multi-runner module queue.tf:

resource "aws_sqs_queue_policy" "webhook_events_workflow_job_queue_policy" {
  count     = var.enable_workflow_job_events_queue ? 1 : 0
  queue_url = aws_sqs_queue.webhook_events_workflow_job_queue[0].id
  policy    = data.aws_iam_policy_document.deny_unsecure_transport.json
}

@veronicatjan veronicatjan changed the title feat: Attach webhook_events_workflow_job_queue_policy to multi-runner webhook_events_workflow_job_queue feat: Add missing webhook_events_workflow_job_queue_policy to multi-runner webhook_events_workflow_job_queue Apr 16, 2024
@veronicatjan veronicatjan changed the title feat: Add missing webhook_events_workflow_job_queue_policy to multi-runner webhook_events_workflow_job_queue feat: Add missing webhook_events_workflow_job_queue_policy to multi-runner queue.tf Apr 16, 2024
@npalm npalm self-requested a review April 16, 2024 09:30
@npalm npalm changed the title feat: Add missing webhook_events_workflow_job_queue_policy to multi-runner queue.tf fix: Add missing webhook_events_workflow_job_queue_policy to multi-runner queue Apr 18, 2024
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veronicatjan thanks for the improvement

@npalm npalm merged commit a8cba4e into philips-labs:main Apr 18, 2024
41 checks passed
npalm pushed a commit that referenced this pull request Apr 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.10.1](v5.10.0...v5.10.1)
(2024-04-24)


### Bug Fixes

* Add missing webhook_events_workflow_job_queue_policy to multi-runner
queue
([#3848](#3848))
([a8cba4e](a8cba4e))
* **lambda:** bump the aws group in /lambdas with 5 updates
([#3861](#3861))
([6119354](6119354))
* **lambda:** bump typescript from 5.3.3 to 5.4.5 in /lambdas
([#3863](#3863))
([e3f3d77](e3f3d77))
* webhook expects REPOSITORY_ALLOW_LIST env var
([#3856](#3856))
([0006ab9](0006ab9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants