Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for matcher config tiering options #3953

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

Brend-Smits
Copy link
Member

@Brend-Smits Brend-Smits commented Jun 28, 2024

This feature is useful as a workaround when you have a larger number of runner configurations and run into problems where the parameter store limit is being reached (4KB). The limit of Standard is 4KB and Advanced is 8KB.

⚠️ It should be noted that if you changed the parameter store tier for the matcher config manually, this change might override your changes!

Signed-off-by: Brend Smits brend.smits@philips.com

@Brend-Smits Brend-Smits force-pushed the feat/add-matcher-config-tier-option branch from 61ed9e4 to 22fc379 Compare June 28, 2024 09:25
@Brend-Smits Brend-Smits marked this pull request as ready for review June 28, 2024 09:28
@Brend-Smits Brend-Smits requested a review from npalm June 28, 2024 11:31
@Brend-Smits Brend-Smits force-pushed the feat/add-matcher-config-tier-option branch from f7b47e4 to 8eb100e Compare June 28, 2024 13:15
This feature is useful as a workaround when you have a larger number of runner configurations and run into problems where the parameter store limit is being reached (4KB). The limit of Standard is 4KB and Advanced is 8KB.

Signed-off-by: Brend Smits <brend.smits@philips.com>
@Brend-Smits Brend-Smits force-pushed the feat/add-matcher-config-tier-option branch from 8eb100e to 150a798 Compare June 28, 2024 13:16
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the fix. This will fix indeed for the problem for some time. We have to start thinking where to store this configuration on the long run.

@npalm npalm merged commit 5f9d9eb into main Jun 28, 2024
43 checks passed
@npalm npalm deleted the feat/add-matcher-config-tier-option branch June 28, 2024 13:28
npalm added a commit that referenced this pull request Jun 28, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.12.0](v5.11.0...v5.12.0)
(2024-06-28)


### Features

* add support for matcher config tiering options
([#3953](#3953))
([5f9d9eb](5f9d9eb))
* **lambda:** add option to define explicit lambda tags
([#3934](#3934))
([7e98943](7e98943))


### Bug Fixes

* **lambda:** bump braces from 3.0.2 to 3.0.3 in /lambdas
([#3944](#3944))
([1aef82b](1aef82b))
* **lambda:** bump the aws group across 1 directory with 2 updates
([#3955](#3955))
([2e094cf](2e094cf))
* **lambda:** bump the aws group across 1 directory with 6 updates
([#3949](#3949))
([76fe9af](76fe9af))
* **webhook:** Don't log warning when secondary job queue is empty
([#3942](#3942))
([ef25bd4](ef25bd4))
* **webhook:** Don't set `${SQS_WORKFLOW_JOB_QUEUE}` to empty string
([#3943](#3943))
([6c48dff](6c48dff))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Co-authored-by: forest-pr|bot <forest-pr[bot]@users.noreply.github.com>
Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants