New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Telepath channel send #111

Open

Hacklor opened this issue Apr 1, 2019 · 0 comments

Contributor

Hacklor commented Apr 1, 2019

Two different ways to handle errors

throws Error when something goes wrong in the connection
returns JSONRPC error object when other party is unable to execute the JSONRPC request

It would be good to see whether this can be made simpler for a user of the API so that they need to check for errors in a unified way.

Options to consider:

throw an error of a different type when a JSONRPC error is returned by the other party
keep as is, and document the two different types of errors

Hacklor assigned Hacklor and unassigned Hacklor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment