Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace web3 by ethers.js in faucet #129

Open
markspanbroek opened this issue Apr 18, 2019 · 0 comments
Open

Replace web3 by ethers.js in faucet #129

markspanbroek opened this issue Apr 18, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@markspanbroek
Copy link
Contributor

markspanbroek commented Apr 18, 2019

The faucet currently uses the web3.js library to transfer ether. Since we're moving away from web3 it would be nice to refactor the faucet to drop web3 in favour of ethers.js.

An attempt has been made in the 'faucet-replace-web3-by-ether' branch, but although the tests pass, the faucet itself doesn't work when connecting to ganache. It throws an error indicating that the TCP connection to ganache is refused.

Reproducing the error:

  • checkout the 'faucet-replace-web3-by-ether' branch
  • start the demo app: cd workspaces/demo-app && yarn start:all
  • open the demo app at http://localhost:3000
  • switch to the 'Executing Contracts' demo
  • press 'increase by 5'
  • scan QR code with the Cogito app
  • see the connection refused error appear in the terminal where the demo app was started
@markspanbroek markspanbroek added the enhancement New feature or request label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant