Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

flex: 1 1 0% is different from flex: 1 1 0px #266

Open
rpellerin opened this issue Jan 24, 2019 · 2 comments
Open

flex: 1 1 0% is different from flex: 1 1 0px #266

rpellerin opened this issue Jan 24, 2019 · 2 comments

Comments

@rpellerin
Copy link

Regarding bug 4, we should not advise people to replace flex shorthand declarations that contain a unitless third argument with percentages instead of pixels, for flex: 1 1 0% is different from flex: 1 1 0px.
More on the topic: https://bugs.chromium.org/p/chromium/issues/detail?id=495306

@garrettw
Copy link

Generally it is advisable to never use units with 0 in the first place.

@rpellerin
Copy link
Author

We agree on this. But sometimes the code is already there and you just can't replace every occurrence.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants