Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Combine Stack Classes #556

Open
mgsimon opened this issue Nov 6, 2023 · 4 comments
Open

[Feature] Combine Stack Classes #556

mgsimon opened this issue Nov 6, 2023 · 4 comments
Assignees
Labels
enhancement new feature / improvments WIP
Milestone

Comments

@mgsimon
Copy link

mgsimon commented Nov 6, 2023

It is difficult or impossible to get badges for which a longer rides is needed if Peloton supported training sessions are used only.

Combine stacked classes of same type like ride to get a better view about the amount of training and to get badges for longer rides.

Like:

  • 10 min warm-up ride
  • 30 min music ride
  • 15 min climb ride
  • 10 min cool-down ride

with the possibility to convert this stacked classes to one Garmin bike training session in total 65 min.

Maybe with additional check box for a combination which could be identified by the timestamp.

@mgsimon mgsimon added the enhancement new feature / improvments label Nov 6, 2023
@philosowaffle philosowaffle added the research needed needs more research by developer label Nov 19, 2023
@philosowaffle philosowaffle added this to the 5.0.0 milestone Dec 24, 2024
@philosowaffle philosowaffle self-assigned this Dec 24, 2024
@philosowaffle
Copy link
Owner

Have an initial proof of concept working, so definitely planning to incorporate this feature into v5.

  1. Settings
    1. Ability to enable/disable automatic stacking
      1. Default is disabled, no change to P2G behavior
      2. When enabled, P2G will automatically attempt to detect classes that should be stacked
    2. Ability to configure the max amount of time gap allowed between workouts in order to stack them
  2. Stacking logic
    1. Given N workouts, these workouts can be stacked if:
      1. They are all of the same type. For example they are all Cycling, or all Running. You cannot mix and stack a Cycling workout with a Running workout.
      2. They all finished within X seconds of the previous workout
    2. Given N workouts, P2G could create multiple stacks if a large enough time gap exists between some of the workouts
  3. UI Only - Sync Page
    1. A new toggle is added to "force stack" the selected workouts. When enabled, this will ignore the time gap between workouts and allow you to manually stack them anyway (assuming they are of the same type).
    2. Additionally this option is handy for folks who do not want to enable Automatic Stacking, but want to decide manually on a case by case basis when to stack

Some early screenshots:

Image

Image

Image

@philosowaffle philosowaffle removed the research needed needs more research by developer label Jan 18, 2025
@mgsimon
Copy link
Author

mgsimon commented Jan 21, 2025

Image of POC available? 😉

@mgsimon
Copy link
Author

mgsimon commented Jan 22, 2025

@philosowaffle POC in philosowaffle/peloton-to-garmin:pr-validator-*-A?

@philosowaffle
Copy link
Owner

@mgsimon sorry for delay, yes, that set of tags always points to the last PR that was built.... which in this case is still the POC for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature / improvments WIP
Projects
None yet
Development

No branches or pull requests

2 participants