Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Grab reps from time based movements #721

Open
btoconnor opened this issue Jan 20, 2025 · 1 comment
Open

[Feature] Grab reps from time based movements #721

btoconnor opened this issue Jan 20, 2025 · 1 comment
Labels
enhancement new feature / improvments
Milestone

Comments

@btoconnor
Copy link

Is your feature request related to a problem? Please describe.
It would be great if this software pulled the actual rep count from time based movements. Back when the guide was first released, I don't think it was tracking movements for movements that were time based, but now it does. ie, the target might be "do chest fly for 40 seconds", but the Guide will still actively track the number of reps you accomplish.

I looked at #436 , and based on the chatter there it seemed like the best idea at the time (which makes sense) was to guess at the number of reps based on time.

I took a quick look at my most recent workout which was largely time based, and I believe the data is in the API to grab the actual rep count (though it might be necessary to back into it with volume / weight data, not entirely sure, I only took a quick ~2 minute look).

Describe the solution you'd like
I would like the software to pull the rep count, if available, from the Guide API and use that when exporting to Garmin, rather than guessing at it based on time.

Additional context
This software is great so far, thanks for publishing it for us to use!

If it's helpful, I can follow you so that you can look at my most recent data, or I can try to export something directly. Whatever works best.

@btoconnor btoconnor added the enhancement new feature / improvments label Jan 20, 2025
@philosowaffle
Copy link
Owner

Could you send me a link to the workout as an example so I can poke at that data? (it'll be similar steps as described here)

Agreed it would be great to just pull this from Peloton now if its available.

@philosowaffle philosowaffle added this to the 5.0.0 milestone Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature / improvments
Projects
None yet
Development

No branches or pull requests

2 participants