From a16cf5e38421a4cd6510fc50155579ca4220939f Mon Sep 17 00:00:00 2001
From: Vicente Merlo <vicenteamerlo@gmail.com>
Date: Fri, 4 Nov 2022 18:16:39 -0300
Subject: [PATCH] Add unused dependencies check step to CI (#435)

* Adds unused dependency check to CI

* Removes PARSER env var logic
---
 .github/workflows/ci.yml |  8 ++++----
 mix.exs                  | 20 ++++----------------
 2 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 195aef93..fb326842 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -9,9 +9,6 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
-    env:
-      PARSER: ${{ matrix.parser }}
-
     name: Elixir ${{ matrix.elixir }} / OTP ${{ matrix.otp }} with ${{ matrix.parser }}
 
     strategy:
@@ -41,6 +38,9 @@ jobs:
       - name: Install dependencies
         run: mix deps.get
 
+      - name: Check for unused dependencies
+        run: mix deps.unlock --check-unused
+
       - name: Install Rust toolchain
         uses: actions-rs/toolchain@v1
         with:
@@ -54,4 +54,4 @@ jobs:
 
       - name: Run test
         run: |-
-          MIX_ENV=test mix test.$PARSER
+          MIX_ENV=test mix test.${{ matrix.parser }}
diff --git a/mix.exs b/mix.exs
index 8a9e0bfd..09b18a77 100644
--- a/mix.exs
+++ b/mix.exs
@@ -41,28 +41,16 @@ defmodule Floki.Mixfile do
   end
 
   defp deps do
-    # Needed to avoid installing unnecessary deps on the CI
-    parsers_deps = [
-      html5ever: {:html5ever, ">= 0.8.0", optional: true, only: [:dev, :test]},
-      fast_html: {:fast_html, ">= 0.0.0", optional: true, only: [:dev, :test]}
-    ]
-
-    parsers =
-      case System.get_env("PARSER") do
-        nil -> [:fast_html, :html5ever]
-        parser when parser in ~w(html5ever fast_html) -> [String.to_atom(parser)]
-        _ -> []
-      end
-      |> Enum.map(fn name -> Keyword.fetch!(parsers_deps, name) end)
-
     [
       {:jason, "~> 1.1", only: [:dev, :test, :docs]},
       {:earmark, "~> 1.2", only: :dev},
       {:ex_doc, "~> 0.29.0", only: :dev, runtime: false},
       {:benchee, "~> 1.1.0", only: :dev},
       {:credo, ">= 0.0.0", only: [:dev, :test]},
-      {:dialyxir, "~> 1.0", only: [:dev], runtime: false}
-    ] ++ parsers
+      {:dialyxir, "~> 1.0", only: [:dev], runtime: false},
+      {:html5ever, ">= 0.8.0", optional: true, only: [:dev, :test]},
+      {:fast_html, ">= 0.0.0", optional: true, only: [:dev, :test]}
+    ]
   end
 
   defp aliases do