Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relentless task. #746

Merged
merged 6 commits into from
Jan 29, 2018
Merged

Added relentless task. #746

merged 6 commits into from
Jan 29, 2018

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Jul 30, 2017

Inspired by ant-contrib

@@ -3421,6 +3421,88 @@ verbose="true" failonerror="false" /></programlisting>
&lt;echo>Resolved [absolute] path: ${absolute_path}&lt;/echo></programlisting>
</sect2>
</sect1>
<sect1 role="taskdef" xml:id="Relentless">
<title>Relentless</title>
<para> RetrThe &lt;relentless> task will execute all of the nested tasks, regardless of whether one or more of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? "RetrThe"

@siad007 siad007 added this to the 3.0 milestone Aug 22, 2017
@siad007
Copy link
Member Author

siad007 commented Oct 1, 2017

@kenguest would you mind continue the review?

Copy link
Member

@kenguest kenguest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks as though some of the documentation is missing - assuming it's an almost straight copy of http://doc.zengrong.net/apache/ant-contrib/manual/tasks/relentless.html ?

@mrook
Copy link
Member

mrook commented Jan 9, 2018

@siad007 can you address @kenguest 's comment and resolve the conflicts?

@siad007
Copy link
Member Author

siad007 commented Jan 28, 2018

@mrook missing docs added and resolved conflicts

@mrook mrook merged commit 1cf9778 into phingofficial:master Jan 29, 2018
@siad007 siad007 deleted the Relentless branch January 31, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants