-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use slashes in and prefix queue name with type in STOMP #1067
Comments
We hardcoded them because of RabbitMQ. It needs it this way to properly route messages and that was the only broker we tested STOMP with. I guess you use another broker. Which one? The current values should stay there because of backward compatibility promise. Though, We should definitely add a way to configure them. Another idea is to use scheme like this |
Sounds good, I'm on ActiveMQ Artemis. Maybe for now you can just detect the scheme (Doing this ensures the backwards compat, but that frees up the bare |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale. |
I wish we could do it but we cannot as it would break existing projects that use What we could do is to introduce new stomp+bare, or stomp-activemq schema that would work differently from current behavior |
In next version (say 0.11.0) we could do it the way it should be. |
That sounds good! |
Hey @makasim, I just wanted to check to see if there's been any progress on this? If not, is there any way I can fork the current stomp driver and modify it as I need? |
It's a low priority project for me. So, dont expect much. I can review&merge PRs, do a release. That's pretty much it. |
Feel free to fork this repository https://github.com/php-enqueue/stomp |
Totally understand, is it okay if I ping here if I have any bizarro questions? I haven't started yet and I can't imagine I'm going to get really stumped. But just in case 😉 Either way, thank you for the guidance so far. ❤️ |
Sure thing! |
Great. If what I make is deemed worthwhile, it'll obviously be available to incorporate back into enqueue. |
PR opened! |
I've been working with publishing to a STOMP queue and I've noticed that all my messages are prefixed with
/queue/
, which is going against my desired scheme for messages.Looking at
StompDestination
, I see that both the prefix and the slashes are hard-coded.It comes to mind that it probably shouldn't be coded as such because everyone can and should be allowed to have their own conventions around how they namespace jobs (
using.periods
,maybe:colons
,maybe/slashes
,maybe\backslashes
, etc...). Indeed, sometimes those conventions might be completely outside of their control! 😅The text was updated successfully, but these errors were encountered: