Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deprecated #148

Closed
joelwurtz opened this issue Oct 29, 2018 · 5 comments
Closed

Adding deprecated #148

joelwurtz opened this issue Oct 29, 2018 · 5 comments

Comments

@joelwurtz
Copy link
Member

Q A
Bug? no
New Feature? yes
Version 2.x

Would it make sense to add a deprecation flag everywhere the psr can be used directly ?

@sagikazarmark
Copy link
Member

I don't think we need to do that, at least not right now. HTTPlug is still widely used, even our own ecosystem. Once we migrated everything to PSR-18 and the community adoption started as well, we can get back to the question of communicating the "deprecation".

@dbu
Copy link
Contributor

dbu commented Oct 29, 2018

agree with that - lets wait for a while first, and only then start to fade out the httplug interface.

however, i think it would be a good idea to already now make a note in the readme of version 2 of this that new projects should use/typehint PSR-18 directly, and also note that in the phpdoc of our interface that extends the psr interface.

@sagikazarmark
Copy link
Member

however, i think it would be a good idea to already now make a note in the readme of version 2 of this that new projects should use/typehint PSR-18 directly

I did that in a #149

@dbu
Copy link
Contributor

dbu commented Oct 31, 2018

shall we keep this issue open or okay to close it?

@sagikazarmark
Copy link
Member

I think we can't miss the eventual drop of the interface, so I'd say we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants