Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #466

Closed
ruudk opened this issue Oct 23, 2020 · 18 comments
Closed

PHP 8 support #466

ruudk opened this issue Oct 23, 2020 · 18 comments

Comments

@ruudk
Copy link
Contributor

ruudk commented Oct 23, 2020

PHP 8.0 will soon be released (November 26, 2020).

Is this extension compatible?

@sodabrew
Copy link
Contributor

The extension is compatible. A new version will be needed to allow PHP 8 in the packaging file, and I'll be sure to do that after testing with final RCs.

@ruudk
Copy link
Contributor Author

ruudk commented Oct 23, 2020

@sodabrew Thanks. Would it be possible to publish master as devel to PECL registry? That would already allow others to test it with 8.0 RC's on CI.

@dzuelke
Copy link
Contributor

dzuelke commented Nov 12, 2020

Thanks for all the work on this @sodabrew. Looking forward to a stable release on PECL, that'll be useful to have for e.g. us at PaaSes providing the extension to customers :)

@andypost
Copy link

It builds and works with latest stable 8.0 - looks it's good time to tag new release

@mokraemer
Copy link

would be nice to have the release with php 8 support ready. Waiting for this to come.

@suyar
Copy link

suyar commented Dec 10, 2020

./configure --enable-memcached-session --enable-memcached-igbinary --enable-memcached-msgpack --enable-memcached-sasl --enable-memcached-protocol
make -j 8

make error:

/usr/local/php/ext/memcached-3.1.5/php_memcached_server.c: In function 's_invoke_php_callback':
/usr/local/php/ext/memcached-3.1.5/php_memcached_server.c:66:9: error: 'zend_fcall_info' {aka 'struct _zend_fcall_info'} has no member named 'no_separation'
  cb->fci.no_separation = 1;
         ^
make: *** [Makefile:219: php_memcached_server.lo] Error 1
make: *** Waiting for unfinished jobs....
The command '/bin/sh -c docker-php-install ${PHP_EXTENSIONS}' returned a non-zero code: 2

But It is working find without --enable-memcached-protocol

@mokraemer
Copy link

any news here?

@ghost
Copy link

ghost commented Jan 19, 2021

@mokraemer

any news here?

If you wish to develop with it (hopefully not for production), you can try cloning master then building with php8.0-dev

@sodabrew
Copy link
Contributor

sodabrew commented Jan 19, 2021

Just a couple details left before I put out a release - some recent PRs show you the activity to make sure that the extension throws errors in the new style and the new type checks.

@VanessaTang95
Copy link

Just a couple details left before I put out a release - some recent PRs show you the activity to make sure that the extension throws errors in the new style and the new type checks.

Hi, is there any update about the release?

@ruudk
Copy link
Contributor Author

ruudk commented Feb 19, 2021

Please create a tag so that we can start testing it 🙏

@FlintMayers
Copy link

Any progress?

@mokraemer
Copy link

ping...

@PirxDanford
Copy link

We had been blissfully ignorant of the missing support and our acceptance test scenarios with PHP 8 had been using memcached. This explains the weird random session loss that we had been facing.
Also - Ping ;-)

@mokraemer
Copy link

any news?

@aran112000
Copy link

We're now less than 1 month away from PHP 8.1's release and it doesn't appear there's been a release of memcached in nearly 2 years (2019-12-03).

Are there any maintainers for this project that could tag a BETA release in the current state for a PECL release? I see earlier this year @remicollet has merged in some fixes for PHP 8.1 already.

@cmb69 cmb69 mentioned this issue Nov 25, 2021
@remicollet
Copy link
Collaborator

3.2.0RC1 s released

@sodabrew
Copy link
Contributor

Thank you @remicollet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests