Fixed issue wit Symfony6 BC break #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantinPopov
force-pushed
the
fix-symfony6-http-foundation-request-support-bc
branch
from
02a9900 to
524cc75
Compare
|
I wouldn‘t know. Any objections? |
https://github.com/symfony/http-foundation/blob/5.4/Request.php#L52 |
|
@andig Fine with me, please merge. I need it too. |
KonstantinPopov
deleted the
fix-symfony6-http-foundation-request-support-bc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony Bootstraps used HttpFoundation\Request constants for booting application.
in Symfony6 was removed deprecated const Symfony\Component\HttpFoundation\Request::HEADER_X_FORWARDED_ALL
was replaced on. HEADER_X_FORWARDED_FOR | HEADER_X_FORWARDED_HOST | HEADER_X_FORWARDED_PORT | HEADER_X_FORWARDED_PROTO as described on symfony recommendation.