From 6be5019a4bfed889f6776530256b006c27182a04 Mon Sep 17 00:00:00 2001 From: Lander Vanderstraeten Date: Fri, 30 Nov 2018 12:31:45 +0100 Subject: [PATCH] Add php unit bridge --- spec/Task/PhpunitBridgeSpec.php | 9 ++++++++- src/Task/PhpunitBridge.php | 26 +++++--------------------- 2 files changed, 13 insertions(+), 22 deletions(-) diff --git a/spec/Task/PhpunitBridgeSpec.php b/spec/Task/PhpunitBridgeSpec.php index 68145817b..a69c72125 100644 --- a/spec/Task/PhpunitBridgeSpec.php +++ b/spec/Task/PhpunitBridgeSpec.php @@ -106,8 +106,15 @@ function it_runs_the_suite(ProcessBuilder $processBuilder, Process $process, Con $result->isPassed()->shouldBe(true); } - function it_throws_exception_if_the_process_fails(ProcessBuilder $processBuilder, Process $process, ContextInterface $context) + function it_throws_exception_if_the_process_fails( + ProcessBuilder $processBuilder, + Process $process, + ContextInterface $context, + ProcessFormatterInterface $formatter + ) { + $formatter->format($process)->willReturn('format string'); + $arguments = new ProcessArgumentsCollection(); $processBuilder->createArgumentsForCommand('simple-phpunit')->willReturn($arguments); $processBuilder->buildProcess($arguments)->willReturn($process); diff --git a/src/Task/PhpunitBridge.php b/src/Task/PhpunitBridge.php index 74e6f808b..10776b7ff 100644 --- a/src/Task/PhpunitBridge.php +++ b/src/Task/PhpunitBridge.php @@ -3,30 +3,20 @@ namespace GrumPHP\Task; use GrumPHP\Runner\TaskResult; +use GrumPHP\Runner\TaskResultInterface; use GrumPHP\Task\Context\ContextInterface; use GrumPHP\Task\Context\GitPreCommitContext; use GrumPHP\Task\Context\RunContext; use Symfony\Component\OptionsResolver\OptionsResolver; -/** - * PhpunitBridge task - * - * @link https://symfony.com/doc/current/components/phpunit_bridge.html - */ class PhpunitBridge extends AbstractExternalTask { - /** - * @return string - */ - public function getName() + public function getName(): string { return 'phpunitbridge'; } - /** - * @return OptionsResolver - */ - public function getConfigurableOptions() + public function getConfigurableOptions(): OptionsResolver { $resolver = new OptionsResolver(); $resolver->setDefaults([ @@ -44,18 +34,12 @@ public function getConfigurableOptions() return $resolver; } - /** - * {@inheritdoc} - */ - public function canRunInContext(ContextInterface $context) + public function canRunInContext(ContextInterface $context): bool { return ($context instanceof GitPreCommitContext || $context instanceof RunContext); } - /** - * {@inheritdoc} - */ - public function run(ContextInterface $context) + public function run(ContextInterface $context): TaskResultInterface { $config = $this->getConfiguration();