You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am encountering an issue when trying to commit changes. Despite having added errors to the PHPStan baseline and successfully running vendor/bin/phpstan and vendor/bin/grumphp run, GrumPHP fails during the commit process, reporting errors that should have been ignored.
Expected Behavior: I expect GrumPHP to recognize the baseline file and exclude the errors that have been marked as allowed in PHPStan. The baseline file is correctly generated, and the phpstan.neon configuration seems to be in order.
Actual Behavior: GrumPHP is not honoring the PHPStan baseline during the commit process, leading to the detection of errors that should have been ignored based on the baseline file. This issue seems to be specific to the interaction between GrumPHP and PHPStan during the commit workflow.
Steps to reproduce:
Configure GrumPHP with PHPStan and generate a PHPStan baseline.
Introduce errors to a file, add it to the baseline, and attempt to commit.
Observe GrumPHP failing to recognize the baseline during the commit process.
I have verified that PHPStan runs successfully with the generated baseline, and no errors are reported when directly executing vendor/bin/phpstan.
My phpstan.neon config located in root:
v2.2.0
I am encountering an issue when trying to commit changes. Despite having added errors to the PHPStan baseline and successfully running
vendor/bin/phpstan
andvendor/bin/grumphp run
, GrumPHP fails during the commit process, reporting errors that should have been ignored.My configuration
Expected Behavior: I expect GrumPHP to recognize the baseline file and exclude the errors that have been marked as allowed in PHPStan. The baseline file is correctly generated, and the
phpstan.neon
configuration seems to be in order.Actual Behavior: GrumPHP is not honoring the PHPStan baseline during the commit process, leading to the detection of errors that should have been ignored based on the baseline file. This issue seems to be specific to the interaction between GrumPHP and PHPStan during the commit workflow.
Steps to reproduce:
My actions
Run GrumPHP with commit:
git commit -m "Commit message'"
Run GrumPHP:
vendor/bin/grumphp run
Additional Context
I have verified that PHPStan runs successfully with the generated baseline, and no errors are reported when directly executing
vendor/bin/phpstan
.My phpstan.neon config located in root:
The text was updated successfully, but these errors were encountered: