Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process messages to the same message group ID one by one #530

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

phstc
Copy link
Collaborator

@phstc phstc commented Nov 1, 2018

So that "Messages that belong to the same message group are always processed one by one" works as expected.

The message group ID is the tag that specifies that a message belongs to a specific message group. Messages that belong to the same message group are always processed one by one, in a strict order relative to the message group (however, messages that belong to different message groups might be processed out of order).

https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/using-messagegroupid-property.html

Fix #529 (comment)

@phstc phstc force-pushed the poll-when-message-at-the-time-fifo branch 5 times, most recently from d867317 to d1156d0 Compare November 1, 2018 11:23
So that "Messages that belong to the same message group are always processed one by one" works as expected

> The message group ID is the tag that specifies that a message belongs to a specific message group. Messages that belong to the same message group are always processed one by one, in a strict order relative to the message group (however, messages that belong to different message groups might be processed out of order).

> https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/using-messagegroupid-property.html
@phstc phstc force-pushed the poll-when-message-at-the-time-fifo branch from d1156d0 to 6b43869 Compare November 1, 2018 11:38
@phstc phstc merged commit a0a4190 into master Nov 1, 2018
@phstc phstc deleted the poll-when-message-at-the-time-fifo branch November 1, 2018 17:37
@phstc phstc changed the title Poll when message at the time when FIFO Process messages to the same message group ID one by one Nov 1, 2018
@Fito
Copy link

Fito commented Feb 16, 2019

Hello @phstc
My understanding is that SQS handles hiding messages from a given group ID to ensure messages are processed one by one. I don't think Shoryuken consumers should be limited to pulling one message at a time when working with FIFO queues.
I believe this is a feature of SQS FIFO queues and their API should already be taking care of it.
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants