Add delay option into Shoryuken.add_group

[pizza-planet]

• 👋 Hey Pablo! Thanks for all your work on Shoryuken. 😄
• Fixes Delay cannot be set per processing group #454

[phstc]

@lucas-ibotta yay that's great! Thank you. Sorry for the delay to get back to you, I will have a look to this this week and merge it down!

[pizza-planet]

Sounds great. Let me know about lib/shoryuken/environment_loader.rb. I think I'm missing where it parses the YML variables to add the delay into the group.

[pizza-planet]

There's two blockers on this currently:

• Code climate checks that seems ignorable. What do you think about those?
• The tests are passing for me locally with rspec but bundle exec rspec raises a user-defined signal 1 that causes the build to exit with a 1. That's happening on Travis also. Seems like an issue with bundler.

Any insight into these issues?

EDIT: found the issue with the delay tests and refactored it a bit. bundle exec rspec is passing locally for me now.

[pizza-planet]

Cool. Tests are passing now. Just code climate remains.

[phstc]

@lucas-ibotta thanks. I will test it locally to see how it goes. Don't worry about these two feedback from Code Climate - it is fine.

[phstc]

@lucas-ibotta it is looking good, I just left a few minor comments, can you 👀?

BTW did you have a chance to test it locally?

[pizza-planet]

Yes, nice catch. I have been on holiday, but I'll address those points soon and test things out locally. 👌

[pizza-planet]

I made delay public and wrote some tests for it on each polling strategy.

[pizza-planet]

Testing this locally and working out some of the bugs.

[pizza-planet]

I can't track down where this is a 1.0 instead of a 0.0.

[pizza-planet]

Ok, I tested this locally with

# in setup_shoryuken.rb
Shoryuken.configure_server do |config|
  Shoryuken.add_group('no-delay', 5)
  Shoryuken.add_queue("https://sqs.us-east-1.amazonaws.com/../normal-queue", 5, 'no-delay')
  Shoryuken.add_group('delay', 5, delay: 25)
  Shoryuken.add_queue("https://sqs.us-east-1.amazonaws.com/../delay-queue", 5, 'delay')
end

class DelayWorker
  include Shoryuken::Worker
    shoryuken_options queue: 'https://sqs.us-east-1.amazonaws.com/../delay-queue'
                  
  def perform(_sqs_message, body)
    puts "DelayWorker Called with #{body}"
  end
end

class NormalWorker
    include Shoryuken::Worker
    shoryuken_options queue: 'https://sqs.us-east-1.amazonaws.com/../normal-queue'
                  
  def perform(_sqs_message, body)
    puts "NormalWorker Called with #{body}"
  end
end

Then ran bundle exec shoryuken --require ./setup_shoryuken.rb and everything worked!

You should probably also test from this branch to confirm?
There's another new code climate issue about delay that I'm looking into.

[phstc]

@lucas-ibotta great work, thank you! I will have a look/test and get back to you. I may need a couple of days though, but if all is good I will merge it down and release a new version 🍻

[pizza-planet]

Excellent. Thanks! Happy New Year to you too.