Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with trailing slashes in routes #135

Closed
marswill opened this issue Feb 9, 2024 · 1 comment · Fixed by #139
Closed

Issues with trailing slashes in routes #135

marswill opened this issue Feb 9, 2024 · 1 comment · Fixed by #139
Assignees

Comments

@marswill
Copy link
Collaborator

marswill commented Feb 9, 2024

As discussed in #133 (though the issue seems to be in the main branch)

Going to the main page, https://topology.pi-base.org/
then clicking on the spaces tab, then clicking on an individual space, seems to lead to a situation where the tabs on that space (properties and references) have broken links with an extra slash - leading for example to https://topology.pi-base.org/spaces/S000005//references, which gives a 404.

On the other hand, after landing on the 404 page, if one continues to navigate through the site (including going back in the browser), the tabs seem to be repaired and everything works fine.

Also, direct linking to a space's page seems to avoid this issue, e.g., https://topology.pi-base.org/spaces/S000005/

Finally, the same issue appears to happen with individual Properties and Theorems as well.

@StevenClontz
Copy link
Member

I have a hacky solution at #136 to just check for the extra slash and drop it.

What's not clear to me is why sometimes we're linking to /spaces/all/ and sometimes /spaces/all. And why sometimes we successfully redirect /spaces/all/ to /spaces/all and sometims we don't.

@StevenClontz StevenClontz changed the title Tabs on individual space, property, and theorem pages are sometimes broken. Issues with trailing slashes in routes Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants